Kh/dev/add mailtemplate v2 #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add clean Nextcloud App Generator result Co-Authored by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
l10n folder containing en, de, es, fr, it, nl and sv translation files Signed-off-by: Aliza Held <[email protected]>
add ionos logo and spacers Signed-off-by: Aliza Held <[email protected]>
Signed-off-by: Aliza Held <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Nextcloud mail template application that provides customized email templates with IONOS branding. The implementation includes a complete custom email template class that extends Nextcloud's built-in email template functionality.
- Comprehensive application structure setup with proper configuration files
- Custom email template implementation with IONOS-specific branding and styling
- Multi-language support for German, English, French, Spanish, Italian, Dutch, and Swedish
Reviewed Changes
Copilot reviewed 54 out of 61 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/EMailTemplate.php | Core email template class with extensive HTML/CSS styling and IONOS branding |
| lib/AppInfo/Application.php | Basic application bootstrap class |
| appinfo/info.xml | App metadata and dependency configuration |
| composer.json | PHP dependencies and project configuration |
| package.json | Node.js dependencies and build scripts |
| l10n/* | Internationalization files for multiple languages |
| tests/* | Unit test setup and basic API test |
| .github/workflows/* | CI/CD pipeline configuration |
| Various config files | Development tooling setup (webpack, vite, psalm, rector, etc.) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bromiesTM
force-pushed
the
kh/dev/add-mailtemplate-v2
branch
2 times, most recently
from
cbda8a7 to
0a09aec
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 67 out of 76 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bromiesTM
force-pushed
the
kh/dev/add-mailtemplate-v2
branch
from
35b76cd to
a602458
Compare
seriAlizations
force-pushed
the
kh/dev/add-mailtemplate-v2
branch
5 times, most recently
from
45e18e1 to
e83d394
Compare
….php} To better fit naming convention, CustomEMailTemplate.php is now called EMailTemplate.php. This includes all mentions in other files. Signed-off-by: Aliza Held <[email protected]>
Signed-off-by: Aliza Held <[email protected]>
…separated directory Signed-off-by: Kai Henseler <[email protected]>
fix linter warnings (newline) Signed-off-by: Kai Henseler <[email protected]>
…ates placeholder format - update localization to use Application::APP_ID for asset URLs - update HTML templates to use PHP short tags and improve variable handling Signed-off-by: Aliza Held <[email protected]>
…late & change namespace {Mailtemplate => NcwMailtemplate}
Signed-off-by: Aliza Held <[email protected]>
- add PHPUnit MySQL and SQLite workflows for testing - add exclusion for PHPUnit result cache - add coverage option to PHPUnit command in composer.json Signed-off-by: Aliza Held <[email protected]>
seriAlizations
force-pushed
the
kh/dev/add-mailtemplate-v2
branch
from
e83d394 to
48780c5
Compare
…e.php file in unittests
Signed-off-by: Aliza Held <[email protected]>
8 tasks
Signed-off-by: Aliza Held <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.